feat: enhance seed-data discovery with dimension table support and SQL filter analysis #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mattevans
commented
Dec 15, 2025
mattevans
commented
- add support for entity/dimension tables (no time range) via intervalType
- read intermediate transformation SQL to extract WHERE clause filters
- extend discovery prompt to include correlation filters for dimension tables
- add FilterSQL and CorrelationFilter to TableRangeStrategy for precise filtering
- improve fallback discovery to handle entity models and missing ranges
- normalize YAML field names and fix unquoted datetime values in Claude responses
- extend QueryRowCount and GenerateOptions to accept additional SQL filters
- add S3 Cache-Control: no-cache header for fresh seed data downloads
…L filter analysis - add support for entity/dimension tables (no time range) via intervalType - read intermediate transformation SQL to extract WHERE clause filters - extend discovery prompt to include correlation filters for dimension tables - add FilterSQL and CorrelationFilter to TableRangeStrategy for precise filtering - improve fallback discovery to handle entity models and missing ranges - normalize YAML field names and fix unquoted datetime values in Claude responses - extend QueryRowCount and GenerateOptions to accept additional SQL filters - add S3 Cache-Control: no-cache header for fresh seed data downloads
samcm
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.